Hi,
answer to first question is obvious: bc. i found it convenient to do it
this way. I dont understand the second
part of the question. The interval is startSegment <= segment <=
endSegment, so whats wrong with endSegment?
The check in canCopy() is wrong. There has to be a check for begin
selection crossing an tuplet and an different
check for end of selection. A selection can start at the beginning of an
tuplet (and not in middle or end) and
end at the last element of an tuplet (or outside of an tuplet of course).
To select parts of an tuplet the nesting level of nested tuplets must be
considered. Additional code is needed to
transform chord/rest values.
/Werner
On 02/10/2012 08:42 PM, jorgk3 wrote:
> Hello,
>
> I have a question, that most likely Werner can answer best.
>
> When I select a note, either via shift select or lasso select, a range is
> selected.
>
> The selection looks like this:
> class Selection {
> ...
> Segment* _startSegment;
> Segment* _endSegment; // next segment after selection
> ...
>
> The _endSegment is really populated with the next segment containing a note
> (so not the segment with the barline if the last note in a bar is selected).
>
> First question: Why? How do we know where the selection ends?
>
> Now look at the triplet checking logic:
> bool Selection::canCopy() const
> {
> if (_state != SEL_RANGE)
> return true;
>
> for (int staffIdx = _staffStart; staffIdx != _staffEnd; ++staffIdx) {
> if (isInMiddleOfTuplet(_startSegment->element(staffIdx)))
> return false;
> if (_endSegment&&
> isInMiddleOfTuplet(_endSegment->element(staffIdx)))
> return false;
> }
> return true;
> }
>
> This checks that start segment is not in the middle of a tuplet and that the
> end segment is not in the middle of a tuplet.
>
> Take the example of triplets: Say we have 2/4 time and 1/8 triplets, so:
> (1 2 3) (4 5 6).
>
> If I shift select 1, start segment will be 1, end segment 2, the test fails,
> since 2 is in the middle.
> If I shift select 2, start segment will be 2, end segment 3, the test fails,
> since 3 is in the middle.
> But now:
> If I shift select 3, start segment will be 3, end segment 4, the test does
> NOT fail, so the logic detects a valid selection to copy. However, the copy
> causes corruption as can be seen in
http://musescore.org/en/node/14648.
>
> (Note: of course the triplets are chords, so shift select makes sense ;-))
>
> So obviously the test is wrong. But how to fix it? Test the start segment
> and the real last segment of the selection, not the end segment?
>
> Same logic in branch and trunk (select.cpp). So it needs to be fixed in both
> places.
>
> Having said that, of course it would be nice if the test would allow a
> single segment to be copied, but that's further down the track. First we
> need to understand what's going on here.
>
> Or perhaps Werner can implement his solution in the trunk and I'll port it
> back if possible.
>
>
> --
> View this message in context:
http://musescore-developer.685061.n2.nabble.com/Tuplet-logic-tp7273953p7273953.html> Sent from the MuseScore Developer mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> Virtualization& Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
>
http://www.accelacomm.com/jaw/sfnl/114/51521223/> _______________________________________________
> Mscore-developer mailing list
>
[hidden email]
>
https://lists.sourceforge.net/lists/listinfo/mscore-developer>
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Locked
